Changeset 2815 for trunk

Timestamp:

11/12/2008 11:02:43 AM (8 weeks ago)

Author:

guyer

Message:

Fix for ticket:159.

Masked values returned from self.mesh._getCellFaceIDs() get converted to
-1 and the C code erroneously tries to use that to index into
faceVariable.

Files:

• trunk/fipy/variables/addOverFacesVariable.py (modified) (1 diff)

trunk/fipy/variables/addOverFacesVariable.py

@@ -71 +71 @@
           for(j = 0; j < numberOfCellFaces; j++)
             {
-              value[i] += orientations[i + j * numberOfCells] * faceVariable[ids[i + j * numberOfCells]];
+              // _getCellFaceIDs() can be masked, which caused subtle and 
+              // unreproduceable problems on OS X (who knows why not elsewhere)
+              long id = ids[i + j * numberOfCells];
+              if (id >= 0) { 
+                  value[i] += orientations[i + j * numberOfCells] * faceVariable[ids[i + j * numberOfCells]];
+              }
             }
             value[i] = value[i] / cellVolume[i];